carsten
706c6d5828
POST /public/routes/{id}/orders and GET .../current-round are the
first fully unauthenticated routes in the app — no CurrentUser or
org-scoping helper applies, route_id comes straight from the URL.
Participant identification matches the old system's no-login design:
an existing participant (case-insensitive email match on the route) is
reused, and — per explicit user correction — its name/phone/is_active
are overwritten from the submission every time, since there's no login
or "edit my details" page; the order form *is* how members keep their
contact info current. is_active is a checkbox on the form itself
(default true), not inferred. A new email always creates a new
participant row — that's the deliberate no-login way to "change
email". An IntegrityError race on concurrent same-email submissions
falls back to re-selecting the winner rather than 500ing.
Order confirmation email reuses 7b's render/send/log pattern for a
single participant, but a missing order_confirmed template (or missing
route sender identity) is a silent no-op + logger.warning, never a
blocking error — an admin configuration gap must never stop a real
order, unlike task 7b's admin-triggered /announce which fails fast on
the same conditions.
Per explicit user correction, the confirmation email deliberately
reproduces the old system's full-catalog receipt (every wine in the
round, grouped by category, ordered quantity filled in where
applicable) — confirmed via old-emails/Kvitering.eml discussion to be
a deliberate mimicry of the physical order sheet used when buying wine
at the producer's cellar, not a legacy-template artifact to simplify
away. Currency totals are computed at full Decimal precision (EUR
summed, then × eur_dkk_rate with no intermediate rounding) and only
rounded to 2dp (ROUND_HALF_UP) at final display formatting, per
correction — avoids compounding an early rounding error into the DKK
figure.
Empty order_lines is rejected with 400 (not the Pydantic-level 422 a
schema constraint would give) — the old empty-order signup/unsubscribe
hack is intentionally not resurrected here; a real signup/unsubscribe
flow is a separate future task per the user's own framing.
Verified end-to-end directly against the real route 4: a temporary
open round + wine offerings + order_confirmed template, a real order
submitted and a real confirmation email sent/logged, a second order
with the same (differently-cased) email confirmed to update the
existing participant in place rather than duplicate it, a
different-round wine_offering_id rejected (400), an empty order
rejected (400 not 422), and the missing-template case confirmed to
still return 201 with no new MailLog row. All temporary data removed
afterward; the real participant (carsten@itkon.dk, id 133) — legitimately
touched by the get-or-create-with-update logic during testing, exactly
as designed — was restored to its original name/phone/is_active. The
other 307 real participants were untouched throughout.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
30 lines
947 B
Python
30 lines
947 B
Python
from typing import TYPE_CHECKING, Optional
|
|
|
|
from sqlalchemy import CheckConstraint
|
|
from sqlmodel import Field, Relationship, SQLModel
|
|
|
|
if TYPE_CHECKING:
|
|
from app.models.order import Order
|
|
from app.models.wine_offering import WineOffering
|
|
|
|
|
|
class OrderLineBase(SQLModel):
|
|
quantity: int = Field(gt=0)
|
|
|
|
|
|
class OrderLine(OrderLineBase, table=True):
|
|
__tablename__ = "order_line"
|
|
__table_args__ = (CheckConstraint("quantity > 0", name="ck_order_line_quantity_positive"),)
|
|
|
|
id: Optional[int] = Field(default=None, primary_key=True)
|
|
order_id: int = Field(foreign_key="orders.id", ondelete="CASCADE")
|
|
wine_offering_id: int = Field(foreign_key="wine_offering.id", ondelete="RESTRICT")
|
|
|
|
order: "Order" = Relationship(back_populates="order_lines")
|
|
wine_offering: "WineOffering" = Relationship(back_populates="order_lines")
|
|
|
|
|
|
class OrderLinePublic(OrderLineBase):
|
|
id: int
|
|
order_id: int
|
|
wine_offering_id: int
|